firecracker: simplify chroot provisioning #4868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having firecracker-go-sdk hardlink files into the chroot for us, we now create the files directly in the chroot. This is required in order to use FUSE for the disk image files, since the SDK's hardlink attempt would fail as it crosses filesystem boundaries. It also results in simpler code - the current
tempDirapproach was purely working around the SDK's hardlinking behavior.This requires patching the go SDK to skip hardlinking in the case where the file is already inside the chroot. I have sent firecracker-microvm/firecracker-go-sdk#510 to upstream the patch.
Related issues: N/A