SUP-4218: Parity between host environment variable and those propagated to container in Docker plugin #291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUILDKITE_TRACING_BACKEND
,BUILDKITE_TRACING_SERVICE_NAME
,BUILDKITE_TRACING_PROPAGATE_TRACEPARENT
,BUILDKITE_TRACING_TRACEPARENT
,BUILDKITE_TRACE_CONTEXT_ENCODING
BUILDKITE_AGENT_JWKS_FILE
,BUILDKITE_AGENT_JWKS_KEY_ID
,BUILDKITE_AGENT_AWS_KMS_KEY
BUILDKITE_ANALYTICS_TOKEN
,BUILDKITE_TEST_SUITE_SLUG
BUILDKITE_CANCEL_GRACE_PERIOD
,BUILDKITE_COMMAND_EVAL
,BUILDKITE_LAST_HOOK_EXIT_STATUS
,BUILDKITE_LOCAL_HOOKS_ENABLED
,BUILDKITE_NO_HTTP2
,BUILDKITE_PLUGIN_VALIDATION
,BUILDKITE_PLUGINS_ENABLED
,BUILDKITE_REDACTED_VARS
,BUILDKITE_SHELL
,BUILDKITE_SIGNAL_GRACE_PERIOD_SECONDS
,BUILDKITE_SSH_KEYSCAN
,BUILDKITE_STRICT_SINGLE_HOOKS
BUILDKITE_GIT_CHECKOUT_FLAGS
,BUILDKITE_GIT_CLEAN_FLAGS
,BUILDKITE_GIT_CLONE_FLAGS
,BUILDKITE_GIT_CLONE_MIRROR_FLAGS
,BUILDKITE_GIT_FETCH_FLAGS
,BUILDKITE_GIT_MIRRORS_LOCK_TIMEOUT
,BUILDKITE_GIT_MIRRORS_PATH
,BUILDKITE_GIT_MIRRORS_SKIP_UPDATE
,BUILDKITE_GIT_SUBMODULES
BUILDKITE_REQUEST_HEADER_BUILDKITE_PIPELINES_SHARD_ID
I decided against including the following:
Agent-Specific Variables (9):
BUILDKITE_AGENT_PID
- Agent process IDBUILDKITE_BUILD_PATH
- Agent build directoryBUILDKITE_SOCKETS_PATH
- Agent sockets directoryBUILDKITE_CONFIG_PATH
- Agent config file pathBUILDKITE_HOOKS_PATH
- Agent hooks directoryBUILDKITE_PLUGINS_PATH
- Agent plugins directoryBUILDKITE_BIN_PATH
- Agent binary pathBUILDKITE_BUILD_CHECKOUT_PATH
- Agent-specific checkout pathBUILDKITE_ENV_FILE
- Env file path (agent-specific)BUILDKITE_ENV_JSON_FILE
- JSON env file pathSecurity-Sensitive Variables (3):
BUILDKITE_AGENT_ACCESS_TOKEN
- Agent's access tokenBUILDKITE_AGENT_JOB_API_TOKEN
- Job API tokenBUILDKITE_AGENT_JOB_API_SOCKET
- Agent job API socket pathAgent Configuration Variables (10):
BUILDKITE_AGENT_DEBUG
- Agent debug modeBUILDKITE_AGENT_DEBUG_HTTP
- Agent debug settingBUILDKITE_AGENT_DISABLE_WARNINGS_FOR
- Agent warning configBUILDKITE_AGENT_ENDPOINT
- Agent API endpointBUILDKITE_AGENT_EXPERIMENT
- Agent experimental featuresBUILDKITE_ADDITIONAL_HOOKS_PATHS
- Agent hook pathsThese 23 variables were excluded because they either:
The 32 included variables focus specifically on job execution context, build configuration, git operations, tracing, and pipeline signing - all directly relevant for containerized job execution while maintaining proper security boundaries.