Refactor plugin config -> envar generation #3655
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhming0
approved these changes
Jan 7, 2026
Contributor
zhming0
left a comment
zhming0
left a comment
There was a problem hiding this comment.
Looks good to me, much easier to read! I wonder if we can just have one tiny e2e test case that uses some plugin? just so this code path is test covered.
I was in this code investigating an escalation, and found it quite hard to parse out what was going on, so i did a couple of light refactors to make it a little easier to follow
moskyb
force-pushed
the
refactor-plugin-envar-generation
branch
from
53cc8c9 to
52d8601
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was in this code investigating an escalation, and found it quite hard to parse out what was going on, so i did a couple of light refactors to make it a little easier to follow. It stops the envar generation process from reparsing lists of envars, and generally shuffles things around a wee bit.
This PR is fairly low-value, and at best has no impact on the agent at runtime. I'm happy to close it and move on with my life, if we want.
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
There was a wee bit of Amp (Claude Opus 4.5) involved in minor refactors, name choosing etc.