Expose pagination in list artifacts schema #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add TestListArtifactsPagination with tests for first page, second page, last page, and beyond available data - Add TestListArtifactsPaginationDefaults to verify default pagination behavior - Tests verify that pagination parameters are properly passed to the underlying API client - Follows same testing pattern as other list functions (jobs, builds, etc.)
There was a problem hiding this comment.
Pull Request Overview
This PR exposes pagination parameters in the list_artifacts schema to match existing patterns used in other endpoints like list_jobs. The change allows clients to specify page and perPage parameters when listing artifacts.
- Adds pagination parameters (page and perPage) to the list_artifacts tool schema
- Implements comprehensive test coverage for pagination functionality including edge cases
- Maintains consistency with existing pagination patterns across the codebase
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/buildkite/artifacts.go | Adds page and perPage parameters to the list_artifacts tool schema with appropriate validation |
| pkg/buildkite/artifacts_test.go | Adds comprehensive test coverage for pagination functionality including edge cases and default behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@lucasconti-dev I have unblocked the pipeline and it highlighted a couple of linting issues, could you resolve those please. This looks like a good improvement so I would love to get it merged and test it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed list_artifact did not expose pagination params in the schema despite supporting them, this PR matches existing patterns like in list_jobs