Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 18bf9fa033
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cad7045b92
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
catkins
left a comment
There was a problem hiding this comment.
This looks great, and awesome that you could also lean on that go container registry pkg for some of the boring OCI things.
When this is in a more stable shape, having some kind of functional tests that run on an elastic stack on a on a real EC2 host with nested virtualisation enabled that test the whole process E2E would be a nice addition.
|
Test summary from local validation on
|
Summary
sandbox.image.refin policy compilation and capture image digest metadatainternal/imagemgrfor OCI pull/extract/import, ext4 materialisation, XDG cache storage, and SQLite metadatacleanroom image pull|ls|rm|importCLI commandsimage_refandimage_digestthrough run responses and execution stream eventsorigin/mainrun_dirfallback wiring and stale host-passthrough references)cleanroom.yamlto a reachable digest-pinned image ref/usr/local/bin/cleanroom-guest-agentand/sbin/cleanroom-initdoctorchecksTesting
mise run test-fullmise run installcleanroom policy validatecleanroom image pull docker.io/library/alpine@sha256:25109184c71bdad752c8312a8623239686a9a2071e8825f20acb8f2198c3f659CLEANROOM_HOST=unix:///tmp/cleanroom-rebase-smoke.sock cleanroom exec -c /tmp/cleanroom-adhoc --launch-seconds=20 -- echo runtime-injection-ok-after-rebase