Skip to content

Parameterise ASG Termination Policies #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Parameterise ASG Termination Policies #1107

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab05620
Parameterise ASG Termination Policies
mf-lit Apr 21, 2023
286843e
Merge branch 'main' into termination_policies
mf-lit Aug 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions templates/aws-stack.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ Metadata:
- InstanceCreationTimeout
- ScalerEventScheduleRate
- ScalerMinPollInterval
- TerminationPolicies

- Label:
default: Cost Allocation Configuration
Expand Down Expand Up @@ -350,6 +351,11 @@ Parameters:
Type: String
Default: ""

TerminationPolicies:
Description: Optional - Autoscaling Group termination policies
Type: CommaDelimitedList
Default: "OldestLaunchConfiguration,ClosestToNextInstanceHour"

RootVolumeSize:
Description: Size of each instance's root EBS volume (in GB)
Type: Number
Expand Down Expand Up @@ -1288,9 +1294,7 @@ Resources:
- GroupTerminatingInstances
- GroupPendingInstances
- GroupDesiredCapacity
TerminationPolicies:
- OldestLaunchConfiguration
- ClosestToNextInstanceHour
TerminationPolicies: !Ref TerminationPolicies
NewInstancesProtectedFromScaleIn: true
CreationPolicy:
ResourceSignal:
Expand Down