Only redact non-short secrets ending in suffix#145
Open
DrJosh9000 wants to merge 1 commit intomainfrom
Open
Conversation
JoeColeman95
approved these changes
Nov 20, 2025
|
Damn, I only saw you opened this after I worked on it and opened my own PR #146 😅
That being said, mine adds unit tests too, so maybe still worth a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Addresses buildkite/agent#3588
Unlike the standard environment-variable-based secret redaction in the agent, which implements the two rules above,
buildkite-agent redactor addwill add nearly any arbitrary string to the redactors for the current job. This behaviour allows users to more flexibly redact particular strings that don't necessarily conform to the default limits by callingbuildkite-agent redactor add. Since we're calling it, we should apply the default rules.