Enable using cache registry for the first build

[mtparet]

Registry caching was disabled for the first build although it permits to share cache between images. This will speed lot of first builds.

[mtparet]

Hi @chenbh, any chance to get a review ? Thanks 🙏

[chenbh]

@mtparet it looks like GitHub Actions didn't pick up your commit for whatever reason, can you try regenerating the commit hash and force pushing?

git commit --amend --no-edit
git push -f

[mtparet]

@chenbh thanks! Just did it but it seems you need to approve the workflow to run here below :

If you are comfortable with running workflows on the pull request branch, return to the Conversation tab, and under "Workflow(s) awaiting approval", click Approve and run.

https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/approving-workflow-runs-from-public-forks#approving-workflow-runs-on-a-pull-request-from-a-public-fork

[chenbh]

I swear that button wasn't there last time 😅.

@mtparet One of the tests is failing

[mtparet]

@chenbh I believe you :D

I fixed the test, the way we select the container based on its position in the initContainers array is not very reliable and we were not testing the right container. I added a function to select the container based on the name, I can open a future PR to convert all existing tests so we ensure we test right containers everywhere.

[mtparet]

(I need an approval on the workflow to trigger the test again)

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.31%. Comparing base (49014e2) to head (beaa711).
Report is 95 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1767       +/-   ##
===========================================
- Coverage   67.34%   35.31%   -32.03%     
===========================================
  Files         140      257      +117     
  Lines        8886    19964    +11078     
===========================================
+ Hits         5984     7051     +1067     
- Misses       2393    12311     +9918     
- Partials      509      602       +93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mtparet]

Tests passed :) Is there anything left I should do to get it merged @chenbh ?

[mtparet]

Thanks @tomkennedy513 !