feat: allow buildpacks with empty stacks#1825
Merged
tomkennedy513 merged 1 commit intobuildpacks-community:mainfrom Feb 25, 2025
Merged
feat: allow buildpacks with empty stacks#1825tomkennedy513 merged 1 commit intobuildpacks-community:mainfrom
tomkennedy513 merged 1 commit intobuildpacks-community:mainfrom
Conversation
As of 0.10, stacks are deprecated and optional: https://github.com/buildpacks/spec/blob/buildpack/v0.10/buildpack.md#buildpacktoml-toml-stacks-array This allows the stacks to be empty during validation. Fixes buildpacks-community#1730
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1825 +/- ##
===========================================
- Coverage 67.34% 35.32% -32.03%
===========================================
Files 140 257 +117
Lines 8886 19965 +11079
===========================================
+ Hits 5984 7052 +1068
- Misses 2393 12311 +9918
- Partials 509 602 +93 ☔ View full report in Codecov by Sentry. |
natalieparellano
approved these changes
Feb 24, 2025
natalieparellano
left a comment
natalieparellano
left a comment
There was a problem hiding this comment.
I'm not a maintainer, but this looks good to me
tomkennedy513
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of 0.10, stacks are deprecated and optional:
https://github.com/buildpacks/spec/blob/buildpack/v0.10/buildpack.md#buildpacktoml-toml-stacks-array
This allows the stacks to be empty during validation.
Fixes #1730