Open
Conversation
Signed-off-by: Joey Brown <brown.joseph@salesforce.com>
joeybrown-sf
force-pushed
the
arm64-tests
branch
from
4d9e585 to
afa3e21
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #283 +/- ##
===========================================
- Coverage 58.29% 39.35% -18.94%
===========================================
Files 32 35 +3
Lines 3694 3256 -438
===========================================
- Hits 2153 1281 -872
- Misses 1184 1781 +597
+ Partials 357 194 -163 |
|
|
||
| // based on static base image refs | ||
| expectedTime := time.Date(2018, 10, 2, 17, 19, 34, 239926273, time.UTC) | ||
| expectedTime := time.Date(2024, 9, 26, 21, 31, 42, 0, time.UTC) |
Member
There was a problem hiding this comment.
Just curious, this changed for linux/amd64 also, no? How does it still work if the linux/amd64 image digest stayed the same?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated tests to make them runnable on arm64 machine.