Take two: Make local/docker implementation platform-aware#305
Draft
bojidar-bg wants to merge 1 commit intobuildpacks:mainfrom
Draft
Take two: Make local/docker implementation platform-aware#305bojidar-bg wants to merge 1 commit intobuildpacks:mainfrom
bojidar-bg wants to merge 1 commit intobuildpacks:mainfrom
Conversation
Signed-off-by: Bozhidar Marinov <bozhidar.marinov1@mail.schwarz>
bojidar-bg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(WIP) Second attempt at #302 after buildpacks/lifecycle#1605.
Will have to test it more substantially this time around, but poking around the
failed to export: saving image: failed to fetch base layers:error, I discovered that:docker image inspect --platform ...is completely useless for use with other commands. Hence, we run both a platform-specific inspect for the layer info and a platform-agnostic inspect for the image ID.ensureLayerscallsImageSavewhich also has a--platformargument. Unsure whatensureLayersis needed for exactly, but it fetches the right layers with the platform set; I still need to test the lifecycle with that change added/removed to see what breaks.ImageHistory,ImageLoad, andImageRemovealso have platform arguments. Investigate if they are needed.