Fix: Update Set<T> to List<T> in calendar_event.dart to comply with rrule 0.2.16#531
Open
sheng-di wants to merge 1 commit intobuilttoroam:developfrom
Open
Fix: Update Set<T> to List<T> in calendar_event.dart to comply with rrule 0.2.16#531sheng-di wants to merge 1 commit intobuilttoroam:developfrom
sheng-di wants to merge 1 commit intobuilttoroam:developfrom
Conversation
Closed
Contributor
|
@sheng-di thank you for fixing the example project that causes all tests to break. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the type declaration change in the
rrulelibrary version 0.2.16. The library now usesList<T>instead ofSet<T>, which necessitates the same change incalendar_event.dartof thebuilttoroam/device_calendarpackage.Changes made:
Set<T>incalendar_event.darthave been updated toList<T>.Set<T>are made to handleList<T>.This change ensures compatibility with the
rrulelibrary version 0.2.16 and prevents possible type errors. It is recommended to merge this PR to maintain the integrity and functionality of thebuilttoroam/device_calendarpackage.Please review and let me know if any changes are required.