Make the EKEventStore instance a Singleton#552
Open
AlexisChoupault wants to merge 1 commit intobuilttoroam:developfrom
Open
Make the EKEventStore instance a Singleton#552AlexisChoupault wants to merge 1 commit intobuilttoroam:developfrom
AlexisChoupault wants to merge 1 commit intobuilttoroam:developfrom
Conversation
dsmailes
reviewed
Nov 14, 2024
Comment on lines
+27
to
+33
| public let eventStore: EKEventStore | ||
|
|
||
| public static let shared = SingleEventStore() | ||
|
|
||
| private init() { | ||
| eventStore = EKEventStore() | ||
| } |
There was a problem hiding this comment.
Doesn't this initialise two instances of EKEventStore?
1: eventStore which doesn't appear to be used, and 2: shared
Author
There was a problem hiding this comment.
I don't think so. The whole point of the Singleton pattern is that the class and its attributes are instantiated only once at runtime.
In my code the only way to instantiate a SingleEventStore is through its static instance shared, which calls the constructor where eventStore is instantiated (only once)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow fixes #551