Fix duplicate margin in cached polyhedral AABBs - #4803
Open
tianrking wants to merge 1 commit into
Open
Conversation
Keep cached polyhedral bounds margin-free so both virtual and nonvirtual AABB paths apply the current collision margin exactly once. Add a convex hull regression covering transformed bounds and runtime margin updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4694
Problem
btPolyhedralConvexAabbCachingShape::recalcLocalAabb()stores support bounds with the collision margin already applied. Both the virtual and nonvirtual AABB paths then pass the current margin tobtTransformAabb, expanding the bounds a second time. Caching the margin also lets a latersetMargin()combine a stale cached value with the new one.Change
btConvexHullShaperegression covering the virtual path, the nonvirtual path, a runtime margin update, and a rotated/translated transform.The regression fails on
masterwith each identity-bound axis over-expanded by exactly one additional margin (for example, expected-1.25but got-1.5).Validation
BulletCollisionandTest_Collision; all 6 collision tests pass.USE_DOUBLE_PRECISION=ON): builtBulletCollisionandTest_Collision; all 6 collision tests pass.-std=c++98): built and ranTest_Collision; all 6 collision tests pass.git diff --check