annotation: make GeneratedAppGlideModuleImpl public to fix Kotlin 2.2.20 visibility warning (#5601)#5660
Open
iVamsi wants to merge 1 commit intobumptech:masterfrom
Open
Conversation
….20 visibility warning (bumptech#5601)
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Kotlin 2.2.20 visibility warning (#5601)
Description
Make
GeneratedAppGlideModuleand the KAPT-generatedGeneratedAppGlideModuleImplpublic.The KSP processor generates
GeneratedAppGlideModuleImplasinternal, which extendsGeneratedAppGlideModule— a Java class with package-private visibility. Kotlin 2.2.20 introduced stricter visibility checks ([KTLC-271] https://youtrack.jetbrains.com/issue/KTLC-271)) that flag this as a warning, and it will become a hard error in Kotlin 2.4:Fix: make
GeneratedAppGlideModulepublic. Since it is by design subclassed across module boundaries by generated code,publicis the correct visibility. The KAPT-generatedGeneratedAppGlideModuleImplis also madepublicfor consistency.Motivation and Context
Fixes #5601.
Kotlin 2.2.20 introduced KTLC-271, which warns (and will error in 2.4) when an
internalKotlin declaration exposes a type with lower visibility. BecauseGeneratedAppGlideModulewas package-private in Java, theinternalKSP-generated subclass triggered this rule. Making the base classpublicresolves the mismatch without changing any user-facing API.