Added Dockerfile#19
Open
ricardobalk wants to merge 3 commits intobunq:developfrom
ricardobalk:docker-setup
Open
Added Dockerfile#19ricardobalk wants to merge 3 commits intobunq:developfrom ricardobalk:docker-setup
ricardobalk wants to merge 3 commits intobunq:developfrom
ricardobalk:docker-setup
Conversation
Author
|
My apologies - I called it an SDK, while it is not an SDK, obviously. Please give me some time to rectify it and test it again. ☕ |
Author
|
Fixed. Ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a Dockerfile, allowing to use this Tinker code within Docker. The main advantage is that Docker gives reproducible results, so you won't have a "but it works on my system" argument with someone.
It's also much easier to test your software, use CI/CD and to provide a cross-platform solution.