Fix: Install casks individually to handle partial download failures (#288)#294
Open
MaximilianPavon wants to merge 1 commit intobuo:masterfrom
Open
Fix: Install casks individually to handle partial download failures (#288)#294MaximilianPavon wants to merge 1 commit intobuo:masterfrom
MaximilianPavon wants to merge 1 commit intobuo:masterfrom
Conversation
Fixes buo#288 Previously, all casks were installed in a single batch command. When Homebrew 5.x pre-fetches downloads and any fail, it aborts the entire operation without installing successfully downloaded casks. Changes: - Pre-fetch all casks in parallel using 'brew fetch' to maintain fast downloads - Install each cask individually to handle partial failures gracefully - Track successful and failed installations separately - Only cleanup old versions for successfully installed casks - Exit with code 1 when any installation fails - Report which casks failed to upgrade at the end
|
Eagerly awaiting this merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #288 - When some downloads fail during
brew cu --all, remaining casks are now still installed and the command exits with a non-zero code.Problem
Previously, all casks were installed in a single batch
brew reinstallcommand. When Homebrew 5.x pre-fetches downloads and any fail, it aborts the entire operation without installing successfully downloaded casks. The command also always exited with code 0 regardless of failures.Solution
brew fetch --caskto maintain fast download performanceTesting
Tested manually on a network that blocks certain download URLs (corporate VPN). Verified that:
Example Output
Details