Open
Conversation
…n remove_auth_method function
ZKEmail Authenticator supporting latest ZKEmail circuits
Updated the zk-email interface to match the dkim module
…ble to generate the signatures
Added allowed-email-hosts field in zk-email auth to whitelist hosts to generate the signatures
🔍 Crucible Security ReviewSummaryAdds ZK Email authenticator support to the Account contract, enabling email-based authentication via DKIM proofs. Integrates with the xion DKIM module for proof verification. Security Assessment
Potential Concerns:
Immunefi Pattern Check
False Report Risk
Code Quality
RecommendationApprove with minor improvements:
|
crucible-burnt
left a comment
There was a problem hiding this comment.
🔍 Crucible Security Review
Summary
Adds gnark-based ZKEmail verification support. Updates CosmWasm dependencies and adds new protobuf/cosmos SDK dependencies.
Security Assessment
- Risk Level: Medium
⚠️ (new ZK functionality) - Dependency updates:
cosmwasm-*2.2.2 → 2.3.2anyhow1.0.100 → 1.0.101bytes1.10.1 → 1.11.1
- New dependencies:
cosmos-sdk-protofrom burnt-labs fork (feat/xion-zkbranch)pbjson,pbjson-types,prost,tendermint-protochronofor timestamp handlingaho-corasickfor pattern matching (likely for email parsing)
Immunefi Pattern Check
- New attack surface: Email verification via ZK proofs
- Custom cosmos-sdk-proto fork requires supply chain review
- No known matches to existing patterns (new functionality)
False Report Risk
- ZKEmail is complex — document security assumptions clearly
- Email parsing has historically been a source of vulnerabilities
Code Quality Notes
- Using forked
cosmos-sdk-protofrom burnt-labs — ensure fork maintenance plan chronoadded withouttzfeature — verify timezone handling is intentionalbitflags 2.10.0added as new dependency- Recommendation: Pin cosmos-sdk-proto to specific commit rather than branch
Status
Requires deeper cryptographic review. ZKEmail implementations need specialist attention. Recommend:
- Document fork maintenance plan for cosmos-sdk-proto
- Ensure email parsing is robust against malformed inputs
- Dedicated ZK circuit audit before mainnet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds in the zk email authenticator into the AA contract