Only calculate price ratios when company in key_ratios is demoninated in USD and allow specifying the specific exchange#50
Open
mwaldstein wants to merge 2 commits intobusiness-science:masterfrom
Conversation
…d only calculate P/E if possible.
Collaborator
|
Thanks for your work on this. Just to give you a heads up, we are working on getting a few pressing needs taken care of at the moment. We'll be working on tq v0.6 shortly though. I encourage you to keep on this, and don't be discouraged if we don't review / implement immediately. It's the nature of the beast with the development cycles. |
Author
|
Not my first rodeo - totally understand. I had a personal need for these changes and am just glad I could share them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revised from previous pull - all in the single key_ratios request now.