Update getrandom for NW.js compatibility#96
Open
qazmlp wants to merge 1 commit intobuttplugio:masterfrom
Open
Conversation
This patch results from running the following command:
```
$ cargo update -p getrandom@0.2.3
Updating crates.io index
Updating getrandom v0.2.3 -> v0.2.8
Updating libc v0.2.109 -> v0.2.137
Updating wasi v0.10.2+wasi-snapshot-preview1 -> v0.11.0+wasi-snapshot-preview1
```
`getrandom`, [in version 0.2.8](https://github.com/rust-random/getrandom/blob/v0.2.8/CHANGELOG.md#028---2022-10-20), comes with better compatibility for hybrid Node/browser environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getrandomwas recently updated to prioritise the Web Cryptography API even when Node.js is present. This makes it compatible with NW.js, which is a hybrid environment of Chromium and Node.js without crypto module.(An old version of) NW.js is used as runtime by RPG Maker MV, so currently I have to
delete process.versions.node;there as workaround in my Intiface plugin for that engine. This may potentially interfere with other plugins.If it's not too much trouble, please update the
buttplugnpm package with this patch applied. I could build this myself otherwise, but doing so without leaking personal info seems a bit tricky.I'm also not keen on shipping a custom binary blob as redistributable here, as there's no effective sandboxing on the players' computers. With an updated npm package that's less niche, game creators can easily verify the checksum or replace the bundled one with a fresh download if necessary.
This patch results from running the following command:
libc v0.2.136should also work, but I assume there's no reason not to update it further.(It seems
getrandom v0.1.16is a build-only dependency, so it's not causing issues.)