Move exception catch for missing natives#99
Open
kitlith wants to merge 3 commits intobuttplugio:masterfrom
Open
Move exception catch for missing natives#99kitlith wants to merge 3 commits intobuttplugio:masterfrom
kitlith wants to merge 3 commits intobuttplugio:masterfrom
Conversation
This should make the "missing natives" message shows up closer to the top of the exception stack, making it more visible.
Contributor
Author
|
hm. looks like CI partially broke. |
Contributor
Author
|
thought: should i change the message from "missing natives" to "failed to load natives"? |
Member
|
That's probably a little clearer yeah. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make the "missing natives" exception more visible, since it'll be closer to the top of the stack.
Also added some handling for setting up a log handler.
while I was working on this, I noticed
callback = (ctx, str) -> cb.log(str);, which is not a static callback like most/every other callback in this library. i should probably fix that at some point.