Enable highlighting in HTML content#21
Open
vincent-psarga wants to merge 1 commit intobvaughn:masterfrom
Open
Conversation
vincent-psarga
added a commit
to cucumber/common
that referenced
this pull request
May 27, 2020
Also enable highlighting dangerouslySetHtml in order to highlight in Markdown components. By default, it will not accept HTML input (or at least will escape it) [PR#21](bvaughn/highlight-words-core#21)
cukebot
pushed a commit
to cucumber/react-components
that referenced
this pull request
Jun 15, 2020
Also enable highlighting dangerouslySetHtml in order to highlight in Markdown components. By default, it will not accept HTML input (or at least will escape it) [PR#21](bvaughn/highlight-words-core#21)
aslakhellesoy
pushed a commit
to cucumber/react-components
that referenced
this pull request
Jan 7, 2022
Also enable highlighting dangerouslySetHtml in order to highlight in Markdown components. By default, it will not accept HTML input (or at least will escape it) [PR#21](bvaughn/highlight-words-core#21)
|
I'm trying to do the same and ended up in this PR, why was it never merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to integrate
react-highlight-wordsin a page where highlighting needs to be done on rendered HTML from one markdown (the project its Cucumber new HTML report).In this PR, I've added a new parameter
htmlTexttofindAllthat tells if the content is HTML. It will not try to highlight the HTML markup, but only the text inside.I've added some test displaying the original behaviour and also the one when the flag is set. I've also updated the documentation.
Another PR should follow soon on
react-highlight-wordsenabling raw HTML to be highlighted.