Relax List rowHeight constraint #852
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bvaughn
force-pushed
the
partial-merge
branch
from
5949963 to
6f40b1c
Compare
bvaughn
force-pushed
the
dynamic-row-heights
branch
from
e6a0344 to
6abbaa3
Compare
bvaughn
force-pushed
the
partial-merge
branch
from
6f40b1c to
1db8b4c
Compare
bvaughn
force-pushed
the
dynamic-row-heights
branch
from
6abbaa3 to
78736a1
Compare
bvaughn
force-pushed
the
partial-merge
branch
from
1db8b4c to
b1aadc0
Compare
bvaughn
force-pushed
the
dynamic-row-heights
branch
from
78736a1 to
3151022
Compare
bvaughn
force-pushed
the
partial-merge
branch
from
b1aadc0 to
4361ba6
Compare
bvaughn
force-pushed
the
dynamic-row-heights
branch
from
3151022 to
c0dcc15
Compare
bvaughn
force-pushed
the
dynamic-row-heights
branch
from
c0dcc15 to
3c327d8
Compare
2 tasks
Owner
Author
|
Closing in favor of #857 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be possible to support optional
rowHeightfor list items (usingResizeObserverto lazily measure items) though there are a few challenges I have yet to work out:scrollToRowwork?rowPropsinvalidation work?How should
scrollToRowwork?The most obvious approach to this would be to set an offset based on estimated sizes, but that can lead to bad UX (scroll jumping) when scrolling backwards (the more off the estimated sizes turn out to be, the bigger the scroll-jumps).
You can see examples of this here:
demo720.mov
An unsatisfying solution for this would be to not support that imperative API method for this props configuration.
How should
rowPropsinvalidation work?Version 1 of this library required external code to manually invalidate row data (by calling an imperative
resetAfterIndexmethod). Version 2 of this library auto-invalidates whenever a value inrowPropschange. This makes for a problem with lazily-measured content: What should happen ifrowPropschanges after the user has scrolled? (Cached sizes and offsets might not be valid anymore, and we can't quickly re-populate the cached bounds.)An unsatisfying solution for this would be to require explicit invalidation for this props configuration.