Fix ResizeObserver being used in the List even when height is provided #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bvaughn
reviewed
Sep 26, 2025
Owner
bvaughn
left a comment
bvaughn
left a comment
There was a problem hiding this comment.
Wow. That's kind of an embarrassing oversight.
Mind doing the same change for Grid?
lib/components/list/List.test.tsx
Outdated
Comment on lines
691
to
695
| window.ResizeObserver = vi.fn(() => ({ | ||
| observe: vi.fn(), | ||
| unobserve: vi.fn(), | ||
| disconnect: vi.fn() | ||
| })); |
Owner
There was a problem hiding this comment.
Suggested change
| window.ResizeObserver = vi.fn(() => ({ | |
| observe: vi.fn(), | |
| unobserve: vi.fn(), | |
| disconnect: vi.fn() | |
| })); | |
| simulateUnsupportedEnvironmentForTest(); |
Contributor
Author
There was a problem hiding this comment.
I’m not sure how this would work. From what I can see in the code, simulateUnsupportedEnvironmentForTest() sets the ResizeObserver to null. However, my goal here is to mock the object so that I can count executions, which is done at the end of the test with expect(window.ResizeObserver).toHaveBeenCalledTimes(0).
Contributor
Author
Sure, updated! |
Owner
|
Setting it to null means that the test would throw if resizeobserver is
even instantiated, which is a stronger guarantee that we don’t use the API
at all.
…On Fri, Sep 26, 2025 at 5:25 AM Tom Najdek ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In lib/components/list/List.test.tsx
<#855 (comment)>:
> + window.ResizeObserver = vi.fn(() => ({
+ observe: vi.fn(),
+ unobserve: vi.fn(),
+ disconnect: vi.fn()
+ }));
I’m not sure how this would work. From what I can see in the code,
simulateUnsupportedEnvironmentForTest() sets the ResizeObserver to null.
However, my goal here is to mock the object so that I can count executions,
which is done at the end of the test with
expect(window.ResizeObserver).toHaveBeenCalledTimes(0).
—
Reply to this email directly, view it on GitHub
<#855 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAHHHM6KCAIWDSOO5SS4EL3UUBAFAVCNFSM6AAAAACHP2ZP3SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTENZRGE2DOOJUG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Contributor
Author
|
Fair point, updated! |
Owner
|
Fix published in [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
styleprop isn’t properly forwarded fromListtouseVirtualizer, hence it’sundefinedhere and the subsequent early return fails. I wrote a quick test and a fix.