Do not show reservoir footprints when it cannot be built #766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to build two linked reservoirs using the "draggable reservoir" feature, if the two reservoirs are in valid placements but the pathfinder does find a way for the aqueduct, the reservoirs displayed some footprints on the map as if they were building but they are not.
This PR proposes to change that so that footprints are shown only if they could be built.
Before:
After:
The call to
map_property_clear_constructing_and_deletedas, with that change, there does not seem to be any code path where bothplace_reservoir_and_aqueductswould return0and footprints would be shown on the map. Correct me if I am wrong though.This is a change from the original Caesar 3 so feel free to close it if it is out of scope.