Conversation
lukevalenta
approved these changes
Feb 20, 2025
Collaborator
lukevalenta
left a comment
lukevalenta
left a comment
There was a problem hiding this comment.
A couple nits, but feel free to ignore!
| @@ -0,0 +1,85 @@ | |||
| // Package umbilical has the temporary logic to back an MTC with an existing | |||
| // X509 certificate chain. | |||
| package umbilical | |||
Collaborator
There was a problem hiding this comment.
Pardon the bikeshed, but what about "bootstrap" as the package name?
Owner
Author
There was a problem hiding this comment.
Bootstrap sounds like something that remains in place 🤔 .
Collaborator
There was a problem hiding this comment.
Hmm I think of a bootstrap as something that's used initially to get a system going, but then isn't needed anymore. Anyway, plenty of time to argue about the naming later :).
Co-authored-by: Luke Valenta <lvalenta@cloudflare.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.