Add NotAfter field to AssertionRequest#20
Merged
lukevalenta merged 1 commit intomainfrom Feb 26, 2025
Merged
Conversation
Collaborator
lukevalenta
commented
Feb 26, 2025
lukevalenta
commented
- Allow an initial notAfter flag to be specified when creating an assertion request. This can only serve to shorten the lifetime of the assertion, so may have limited value.
- Add the minimum of (initial not_after, batch not_after, umbilical not_after) to a queued assertion. Later, this may be added to the abridged assertion and proof.
lukevalenta
force-pushed
the
lvalenta/notafter
branch
from
2d8805b to
8291ecd
Compare
lukevalenta
commented
Feb 26, 2025
ca/ca.go
Outdated
| return err | ||
| } | ||
| // Clear the checksum as it will no longer be valid if NotAfter changes. | ||
| ar.Checksum = nil |
Collaborator
Author
There was a problem hiding this comment.
We could leave the notAfter field out of the checksum so we don't need to reset it, but if we're potentially going to add it to the Assertion later then it probably belongs. It's just a little weird for the checksums to be different before and after an assertion request is queued, but ah well.
We could also reintroduce the QueuedAssertion struct as
type QueuedAssertion struct {
AssertionRequest AssertionRequest
NotAfter time.Time
}
bwesterb
reviewed
Feb 26, 2025
bwesterb
approved these changes
Feb 26, 2025
- Allow an initial notAfter flag to be specified when creating an assertion request. This can only serve to shorten the lifetime of the assertion, so may have limited value. - Add the minimum of (initial not_after, batch not_after, umbilical not_after) to a queued assertion. Later, this may be added to the abridged assertion and proof.
lukevalenta
force-pushed
the
lvalenta/notafter
branch
from
8291ecd to
b9bce7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.