Add support for Enhanced Role Colors Guild Feature#1634
Open
conceaIing wants to merge 4 commits intobwmarrin:masterfrom
Open
Add support for Enhanced Role Colors Guild Feature#1634conceaIing wants to merge 4 commits intobwmarrin:masterfrom
conceaIing wants to merge 4 commits intobwmarrin:masterfrom
Conversation
Adds color validation to restapi.go following previous implementation
Add new Role Colors structs to RoleParams and Role structs
Author
|
Just wanted to follow up and ask if the workflow could be re-ran after I added the comment it failed on |
Co-authored-by: Magnus Jensen <magnushjensen.mail@gmail.com>
Author
|
Would love to get this reviewed and/or signed off on 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new RoleColors struct containing the PrimaryColor, SecondaryColor, and TertiaryColor fields used for Enhanced Role Colors configuration.
Adds RoleColors field to both RoleParams and Role structs.
Adds validation to GuildRoleEdit both matching the existing color size validation and for avoiding trying to use TertiaryColor outside of the Holographic role color. (Trying to do so will otherwise return status code 670008 from the API
{"message": "Invalid role color", "code": 670008})