Skip to content

Conversation

@d-bytebase
Copy link
Contributor

Summary

Add a script to check for broken links in documentation while automatically filtering out /api-reference links, which are known false positives.

Changes

  • New script: mintlify/check-links.sh

    • Runs mint broken-links command
    • Filters out all /api-reference links from results
    • Returns exit code 0 for success, 1 for broken links found
    • Shows clear success/failure messages
  • Simplified workflow: .github/workflows/broken-links.yml

    • Minimal workflow that just runs the script
    • Shows pass/fail status in PR checks
    • Removed unnecessary complexity
  • Documentation: Updated mintlify/CLAUDE.md

    • Added testing section with instructions to run the script
    • Helps maintain documentation quality

Benefits

  • ✅ Eliminates false positives from /api-reference links
  • ✅ Simple and maintainable solution
  • ✅ Clear pass/fail feedback in CI/CD
  • ✅ Can be run locally before committing changes

Testing

Run locally with:

./mintlify/check-links.sh

🤖 Generated with Claude Code

- Add mintlify/check-links.sh script that filters out /api-reference links
- Update GitHub workflow to use the new script for PR checks
- Add testing instructions to CLAUDE.md
- Script returns appropriate exit codes for CI/CD integration

This improves the reliability of documentation link checking by excluding
known false positives from api-reference paths.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Copilot AI review requested due to automatic review settings August 29, 2025 06:35
@vercel
Copy link

vercel bot commented Aug 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
bytebase-com Ready Ready Preview Comment Aug 29, 2025 6:43am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a broken links checking script that automatically filters out /api-reference links to eliminate false positives in documentation validation.

  • Creates a shell script that wraps the mint broken-links command with intelligent filtering
  • Simplifies the GitHub workflow by removing complex comment generation and just running the script
  • Updates documentation with testing instructions for local validation

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
mintlify/check-links.sh New script that filters /api-reference links from broken link results
mintlify/CLAUDE.md Adds testing section with instructions to run the link check script
.github/workflows/broken-links.yml Simplified workflow that executes the script directly without PR comments

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@tianzhou tianzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d-bytebase
Copy link
Contributor Author

@d-bytebase d-bytebase merged commit fcd0ebc into main Aug 29, 2025
4 of 5 checks passed
@d-bytebase d-bytebase deleted the feat/add-broken-links-check-script branch August 29, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants