-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add broken links check script with api-reference filtering #861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add mintlify/check-links.sh script that filters out /api-reference links - Update GitHub workflow to use the new script for PR checks - Add testing instructions to CLAUDE.md - Script returns appropriate exit codes for CI/CD integration This improves the reliability of documentation link checking by excluding known false positives from api-reference paths. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a broken links checking script that automatically filters out /api-reference links to eliminate false positives in documentation validation.
- Creates a shell script that wraps the
mint broken-linkscommand with intelligent filtering - Simplifies the GitHub workflow by removing complex comment generation and just running the script
- Updates documentation with testing instructions for local validation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
mintlify/check-links.sh |
New script that filters /api-reference links from broken link results |
mintlify/CLAUDE.md |
Adds testing section with instructions to run the link check script |
.github/workflows/broken-links.yml |
Simplified workflow that executes the script directly without PR comments |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tianzhou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
example of a failed run: https://github.com/bytebase/bytebase.com/actions/runs/17316630676/job/49160607162 |
Summary
Add a script to check for broken links in documentation while automatically filtering out
/api-referencelinks, which are known false positives.Changes
New script:
mintlify/check-links.shmint broken-linkscommand/api-referencelinks from resultsSimplified workflow:
.github/workflows/broken-links.ymlDocumentation: Updated
mintlify/CLAUDE.mdBenefits
/api-referencelinksTesting
Run locally with:
🤖 Generated with Claude Code