docs: enhance LDAP user filter configuration guide #937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improve User Filter field description with more detail - Add comprehensive User Filter Configuration section - Include provider-specific filter patterns table (Okta, JumpCloud, AD, OpenLDAP) - Document best practices and common issues - Add troubleshooting tips with LDAP browser tool recommendation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the LDAP configuration documentation by providing comprehensive guidance on user filter configuration. The changes transform a brief inline description into a detailed reference guide with provider-specific examples, best practices, and troubleshooting tips.
- Expanded User Filter field description with clearer explanation of the
%splaceholder - Added dedicated "User Filter Configuration" section with detailed guidance, provider-specific patterns, best practices, and troubleshooting tips
- Introduced "Examples" section header to better organize existing provider examples
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zchpeter
reviewed
Nov 12, 2025
Address review feedback to improve clarity: - Convert bullet list to table format - Add Bad Example column with incorrect filter patterns - Add Correction column showing proper fixes - Maintain all four issue types with concrete examples 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of BYT-8361
🤖 Generated with Claude Code