-
Notifications
You must be signed in to change notification settings - Fork 159
feat: multi-statement #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
407cd7d
feat(icons): add XIcon for close buttons
tianzhou 37be65a
feat(tool): add ResultTab type for tabbed results
tianzhou c944b3e
feat(tool): add ResultsTabs component for tabbed query results
tianzhou 0bcd2dc
feat(tool): integrate tabbed results in ToolDetailView
tianzhou 2b59f76
fix(a11y): add aria-labels to tab close button and error indicator
tianzhou 546accd
feat: multi-statement SQL returns per-statement results
tianzhou eec553d
refactor: simplify tab labels to timestamp only
tianzhou 0d97c73
fix: hide vertical scrollbar in tab bar
tianzhou e6e77b4
feat: add arrow buttons for tab navigation
tianzhou a9a24ff
refactor(sqlite): use shared isReadOnlySQL utility
tianzhou a234100
refactor(sqlite): use isReadOnlySQL for single statement too
tianzhou ad2dcbb
Merge branch 'main' into multi-statement
tianzhou c4d5dcc
Update frontend/src/components/views/ToolDetailView.tsx
tianzhou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| interface ChevronLeftIconProps { | ||
| className?: string; | ||
| } | ||
|
|
||
| export default function ChevronLeftIcon({ className = 'w-4 h-4' }: ChevronLeftIconProps) { | ||
| return ( | ||
| <svg className={className} fill="none" viewBox="0 0 24 24" stroke="currentColor"> | ||
| <path strokeLinecap="round" strokeLinejoin="round" strokeWidth={2} d="M15 19l-7-7 7-7" /> | ||
| </svg> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| interface ChevronRightIconProps { | ||
| className?: string; | ||
| } | ||
|
|
||
| export default function ChevronRightIcon({ className = 'w-4 h-4' }: ChevronRightIconProps) { | ||
| return ( | ||
| <svg className={className} fill="none" viewBox="0 0 24 24" stroke="currentColor"> | ||
| <path strokeLinecap="round" strokeLinejoin="round" strokeWidth={2} d="M9 5l7 7-7 7" /> | ||
| </svg> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,9 @@ | ||
| import type { QueryResult } from '../../api/tools'; | ||
| import type { StatementResult } from '../../api/tools'; | ||
|
|
||
| export interface ResultTab { | ||
| id: string; | ||
| timestamp: Date; | ||
| result: QueryResult | null; | ||
| result: StatementResult | null; | ||
| error: string | null; | ||
| executedSql: string; | ||
| executionTimeMs: number; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.