feat: sql selection #217
Merged
feat: sql selection #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds SQL selection functionality to the SQL editor, allowing users to execute only the selected portion of SQL code rather than the entire content. This is a common feature in SQL development tools that improves developer productivity.
Key changes:
- Exposed a
getSelectedSql()method fromSqlEditorvia a ref handle to retrieve either the selected text or full content - Updated
ToolDetailViewto use the selected SQL when executing queries forexecute_sqltools - Implemented the ref pattern using
forwardRefanduseImperativeHandleto access editor selection state
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/src/components/tool/SqlEditor.tsx | Added SqlEditorHandle interface and getSelectedSql() method using forwardRef and useImperativeHandle to expose editor selection state |
| frontend/src/components/tool/index.ts | Exported the new SqlEditorHandle type for external consumption |
| frontend/src/components/views/ToolDetailView.tsx | Added ref to SqlEditor and updated execution logic to use selected SQL when available |
tianzhou
force-pushed
the
select-query
branch
from
71bfaf9 to
7692978
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.