Skip to content

chore: not support change the resource id #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025
Merged

chore: not support change the resource id #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 24 additions & 8 deletions provider/resource_environment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func resourceEnvironment() *schema.Resource {
},
"order": {
Type: schema.TypeInt,
Required: true,
Optional: true,
Description: "The environment sorting order.",
ValidateFunc: validation.IntAtLeast(0),
},
Expand All @@ -67,10 +67,14 @@ func resourceEnvironment() *schema.Resource {

func resourceEnvironmentUpsert(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
c := m.(api.Client)
existedName := d.Id()

newOrder := d.Get("order").(int)
environmentID := d.Get("resource_id").(string)
environmentName := fmt.Sprintf("%s%s", internal.EnvironmentNamePrefix, environmentID)

if existedName != "" && existedName != environmentName {
return diag.Errorf("cannot change the resource id")
}
v1Env := &v1pb.EnvironmentSetting_Environment{
Id: environmentID,
Title: d.Get("title").(string),
Expand All @@ -83,7 +87,7 @@ func resourceEnvironmentUpsert(ctx context.Context, d *schema.ResourceData, m in
v1Env.Tags["protected"] = "unprotected"
}

existedEnv, order, enironmentList, err := findEnvironment(ctx, c, environmentName)
existedEnv, oldOrder, enironmentList, err := findEnvironment(ctx, c, environmentName)
if err != nil {
if !strings.HasPrefix(err.Error(), "cannot found the environment") {
return diag.FromErr(err)
Expand All @@ -93,8 +97,16 @@ func resourceEnvironmentUpsert(ctx context.Context, d *schema.ResourceData, m in
return diag.Errorf("cannot found environment setting")
}

if newOrder >= len(enironmentList) {
return diag.Errorf("the new order %v out of range %v", newOrder, len(enironmentList)-1)
var newOrder int
order, ok := d.GetOk("order")
if !ok {
if existedEnv != nil {
newOrder = oldOrder
} else {
newOrder = len(enironmentList)
}
} else {
newOrder = order.(int)
}

var diags diag.Diagnostics
Expand All @@ -105,10 +117,14 @@ func resourceEnvironmentUpsert(ctx context.Context, d *schema.ResourceData, m in
Detail: fmt.Sprintf("Environment %s already exists, try to exec the update operation", environmentID),
})

if order == newOrder {
enironmentList[order] = v1Env
if newOrder >= len(enironmentList) {
return diag.Errorf("the new order %v out of range %v", newOrder, len(enironmentList)-1)
}

if oldOrder == newOrder {
enironmentList[oldOrder] = v1Env
} else {
enironmentList = slices.Delete(enironmentList, order, order+1)
enironmentList = slices.Delete(enironmentList, oldOrder, oldOrder+1)
enironmentList = slices.Insert(enironmentList, newOrder, v1Env)
}
} else {
Expand Down
5 changes: 5 additions & 0 deletions provider/resource_review_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,15 @@ func resourceReviewConfigDelete(ctx context.Context, d *schema.ResourceData, m i

func resourceReviewConfigUpsert(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
c := m.(api.Client)
existedName := d.Id()

reviewID := d.Get("resource_id").(string)
reviewName := fmt.Sprintf("%s%s", internal.ReviewConfigNamePrefix, reviewID)

if existedName != "" && existedName != reviewName {
return diag.Errorf("cannot change the resource id")
}

rules, err := convertToV1RuleList(d)
if err != nil {
return diag.FromErr(err)
Expand Down