Skip to content

chore: remove deprecated roles LAST_APPROVER and CREATOR #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2025
Merged

chore: remove deprecated roles LAST_APPROVER and CREATOR #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0fff51
chore: remove deprecated roles LAST_APPROVER and CREATOR
d-bytebase Sep 18, 2025
7c17d8f
fix: remove extra blank line to pass goimports check
d-bytebase Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions examples/setup/environment.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,7 @@ resource "bytebase_policy" "rollout_policy" {
automatic = true
roles = [
"roles/workspaceAdmin",
"roles/projectOwner",
"roles/LAST_APPROVER",
"roles/CREATOR"
"roles/projectOwner"
]
}
}
Expand Down
9 changes: 1 addition & 8 deletions provider/data_source_policy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,11 +320,6 @@ func getDataSourceQueryPolicySchema(computed bool) *schema.Schema {
}
}

const (
issueLastApproverRole = "roles/LAST_APPROVER"
issueCreatorRole = "roles/CREATOR"
)

func getRolloutPolicySchema(computed bool) *schema.Schema {
return &schema.Schema{
Computed: computed,
Expand All @@ -348,10 +343,8 @@ func getRolloutPolicySchema(computed bool) *schema.Schema {
Description: "If any roles are specified, Bytebase requires users with those roles to manually roll out the change.",
Elem: &schema.Schema{
Type: schema.TypeString,
Description: fmt.Sprintf(`Role full name in roles/{id} format. You can also use the "%s" for the last approver of the issue, or "%s" for the creator of the issue.`, issueLastApproverRole, issueCreatorRole),
Description: `Role full name in roles/{id} format.`,
ValidateDiagFunc: internal.ResourceNameValidation(
fmt.Sprintf("^%s$", issueLastApproverRole),
fmt.Sprintf("^%s$", issueCreatorRole),
fmt.Sprintf("^%s", internal.RoleNamePrefix),
),
},
Expand Down
6 changes: 1 addition & 5 deletions provider/resource_policy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,11 +496,7 @@ func convertToRolloutPolicy(d *schema.ResourceData) (*v1pb.RolloutPolicy, error)

for _, rawRole := range roles.List() {
role := rawRole.(string)
if role == issueLastApproverRole || role == issueCreatorRole {
policy.IssueRoles = append(policy.IssueRoles, role)
} else {
policy.Roles = append(policy.Roles, role)
}
policy.Roles = append(policy.Roles, role)
}

return policy, nil
Expand Down
8 changes: 2 additions & 6 deletions tutorials/1-2-env-policy-rollout.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@ resource "bytebase_policy" "rollout_policy_test" {
automatic = true
roles = [
"roles/workspaceAdmin",
"roles/projectOwner",
"roles/LAST_APPROVER",
"roles/CREATOR"
"roles/projectOwner"
]
}
}
Expand All @@ -23,9 +21,7 @@ resource "bytebase_policy" "rollout_policy_prod" {
automatic = false
roles = [
"roles/workspaceAdmin",
"roles/projectOwner",
"roles/LAST_APPROVER",
"roles/CREATOR"
"roles/projectOwner"
]
}
}