3796 client - If user types '=' as the very first character, enable formula mode and prevent the '=' from being inserted into the editor #3797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormula mode and prevent the '=' from being inserted into the editor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the behavior when a user types '=' as the first character in the property mentions input editor. Previously, the '=' character would be inserted into the editor before formula mode was enabled. Now, formula mode is enabled and the '=' character insertion is prevented.
Key Changes:
- Split the combined conditional logic into two separate blocks for better control flow
- Added
event.preventDefault()to block the '=' character from being inserted when typed in an empty editor - Formula mode is now enabled before any character insertion occurs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Collaborator
|
@ivicac ja već imam fix za ovo u pripremi, tako da ću zatvoriti ovaj PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.