732 Suspend - action definition updates #3800
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the action definition API to support suspend/resume functionality as part of issue #732. The changes introduce a new type hierarchy for perform and output functions, where BasePerformFunction and BaseOutputFunction serve as parent interfaces, with PerformFunction and OutputFunction as specialized implementations for single-connection scenarios, and MultipleConnectionsPerformFunction/MultipleConnectionsOutputFunction for multi-connection scenarios.
Key changes include:
- Renaming
SingleConnectionPerformFunctiontoPerformFunctionandSingleConnectionOutputFunctiontoOutputFunction - Introducing base types (
BasePerformFunction,BaseOutputFunction) to support both single and multiple connection patterns - Adding new suspend/resume related fields (
resumePerformFunction,suspendPerformFunction, etc.) to action definitions
Reviewed changes
Copilot reviewed 240 out of 240 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ActionDefinitionServiceImpl.java | Updates type handling to use base types and cast to appropriate subtypes based on connection patterns |
| OpenApiComponentHandlerLoader.java | Changes function type from SingleConnectionPerformFunction to PerformFunction |
| DefaultComponentHandlerLoader.java | Updates function type references for component handlers |
| ActionDefinition.java | Updates type checking logic for perform function to use new PerformFunction type |
| MultipleConnectionsPerformFunction.java | Changes to extend BasePerformFunction instead of PerformFunction |
| MultipleConnectionsOutputFunction.java | Changes to extend BaseOutputFunction instead of OutputFunction |
| ActionDefinitionWrapper.java | Updates field and method types to use base types |
| AbstractActionDefinitionWrapper.java | Adds new suspend/resume fields and updates return types |
| ScriptActionDefinition.java | Changes return type to be more specific (MultipleConnectionsPerformFunction) |
| Test files (multiple) | Updates test code to handle new type hierarchy with proper casting |
| JSON definition files (multiple) | Adds new null fields for suspend/resume functionality to generated test resources |
| HttpClientActionUtils.java | Updates method return type from SingleConnectionPerformFunction to PerformFunction |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ivicac
force-pushed
the
732
branch
3 times, most recently
from
a78808c to
ed01a06
Compare
|
No description provided.