1652 Refactor PineconeConstants to remove caching logic for vector stores #3804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the Caffeine-based caching mechanism from PineconeConstants, simplifying the vector store initialization logic. The refactoring aligns Pinecone's implementation with other vector store components in the codebase that don't use caching.
- Removes Caffeine cache dependency and associated caching logic
- Simplifies VECTOR_STORE lambda to directly create PineconeVectorStore instances
- Cleans up unused imports (Caffeine, TimeUnit)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| PineconeConstants.java | Removed Caffeine cache wrapper and simplified VECTOR_STORE implementation to directly instantiate PineconeVectorStore without caching |
| build.gradle.kts | Removed Caffeine dependency that is no longer needed after cache removal |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...src/main/java/com/bytechef/component/ai/vectorstore/pinecone/constant/PineconeConstants.java
Outdated
Show resolved
Hide resolved
… VECTOR_STORE initialization
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.