Conversation
The hasExpressionVariable method was incorrectly matching parameter names inside quoted string literals, causing parameters to be removed when the option value equaled the parameter name (e.g., type == 'type'). The fix strips single and double quoted string literals from the display condition before checking for variable references. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug in the hasExpressionVariable method where parameter names inside quoted string literals were incorrectly matched as variable references. This caused parameters to be removed when the option value equaled the parameter name (e.g., type == 'type').
Changes:
- Modified
hasExpressionVariableto strip quoted string literals before checking for variable references - Added comprehensive test cases to verify the fix handles various scenarios with string literals
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| WorkflowNodeParameterFacadeImpl.java | Added regex pattern to remove single and double quoted string literals before matching parameter names |
| WorkflowNodeParameterFacadeTest.java | Added test method testHasExpressionVariableIgnoresStringLiterals with 8 test cases covering string literals in display conditions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...rc/main/java/com/bytechef/platform/configuration/facade/WorkflowNodeParameterFacadeImpl.java
Outdated
Show resolved
Hide resolved
...rc/test/java/com/bytechef/platform/configuration/facade/WorkflowNodeParameterFacadeTest.java
Show resolved
Hide resolved
Address PR review feedback by updating the regex pattern to correctly handle escaped quotes in string literals like 'it\'s' or "He said \"hello\"". Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hasExpressionVariable method was incorrectly matching parameter names
inside quoted string literals, causing parameters to be removed when the
option value equaled the parameter name (e.g., type == 'type').
The fix strips single and double quoted string literals from the display
condition before checking for variable references.
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com