Conversation
…agement Implement enterprise OIDC Single Sign-On: IdP domain model with Liquibase migration, IdentityProviderService with encrypted client secrets, DynamicClientRegistrationRepository for runtime provider resolution, SSO discovery endpoint, CustomOidcUserService, SSO enforcement filter, GraphQL API for IdP CRUD, admin settings UI, and login page SSO discovery on email blur. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request implements enterprise OIDC Single Sign-On (SSO) functionality for the ByteChef platform. The feature enables organizations to configure custom identity providers for authentication, providing a seamless SSO experience for users.
Changes:
- Added GraphQL schema and API for identity provider CRUD operations with encrypted client secrets
- Implemented SSO discovery endpoint that detects configured identity providers based on email domain
- Created admin UI for managing identity providers with support for multiple domains, auto-provisioning, and SSO enforcement
- Enhanced login page with automatic SSO discovery on email blur to redirect users to their organization's identity provider
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| client/src/shared/middleware/graphql.ts | Generated GraphQL types, queries, mutations, and hooks for identity provider management |
| client/src/routes.tsx | Added identity-providers route under platform settings with admin-only access |
| client/src/pages/account/public/Login.tsx | Implemented SSO discovery on email blur with UI to redirect users to their identity provider |
| client/src/graphql/platform/user/*.graphql | GraphQL query and mutation definitions for identity provider CRUD operations |
| client/src/ee/pages/settings/platform/identity-providers/stores/*.ts | Zustand stores for managing identity provider dialog and deletion state |
| client/src/ee/pages/settings/platform/identity-providers/components/hooks/*.ts | Custom hooks for identity provider table, dialog, and deletion logic |
| client/src/ee/pages/settings/platform/identity-providers/components/*.tsx | React components for identity provider table, dialog, and alert dialogs |
| client/src/ee/pages/settings/platform/identity-providers/IdentityProvidersPage.tsx | Main page component that orchestrates identity provider management UI |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.../ee/pages/settings/platform/identity-providers/components/hooks/useIdentityProviderDialog.ts
Show resolved
Hide resolved
.../ee/pages/settings/platform/identity-providers/components/hooks/useIdentityProviderDialog.ts
Show resolved
Hide resolved
client/src/ee/pages/settings/platform/identity-providers/components/IdentityProviderDialog.tsx
Outdated
Show resolved
Hide resolved
- Improve email validation to check for text before and after '@' - Add AbortController with 5s timeout to SSO discovery fetch - Add last-checked-email ref to prevent duplicate API calls - Remove unnecessary return event from onBlur handler - Add onError toast notifications to identity provider mutations - Require clientSecret when creating new identity providers Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement enterprise OIDC Single Sign-On: IdP domain model with Liquibase migration,
IdentityProviderService with encrypted client secrets, DynamicClientRegistrationRepository
for runtime provider resolution, SSO discovery endpoint, CustomOidcUserService, SSO
enforcement filter, GraphQL API for IdP CRUD, admin settings UI, and login page SSO
discovery on email blur.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com