-
Notifications
You must be signed in to change notification settings - Fork 39
refactor(tests): split up test suites, update docs #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor(tests): split up test suites, update docs #278
Conversation
c0a4cb6
to
0c43f12
Compare
0c43f12
to
6d76607
Compare
OK, so this PR is ready for review, but I'm a little dissatisfied with the consistency of CI -- running with more concurrency seems to have made tests more unstable. Going to re-run the latest job a few more times to make sure it passes most of the time so that the average PR should pass without issues. |
OK unfortunately there were still a couple failures -- (mac/windows + weval). I wonder if we can get away with disabling test concurrency for weval runs... If that's more consistent then I'll go with that, otherwise I'll just disable test-level concurrency all together (suite level concurrency still happens) |
OK, going to rip out concurrency here -- tests consistently passing is more important I think. [EDIT] - Actually the test that is still failing is a Weval one which is timing out... Updating test config to run only one concurrent suite at a time if we're doing that. |
@vados-cosmonic same request I often have: can you update the description here to add some motivation for this? It's so very much easier to review PRs when I know which lens to look through. It's also very useful for looking at changes later on. |
Hey @tschneidereit yeah it's been a while on this PR -- I believe I was trying to finish the switch to In particular this comment here: When not in CI (on really slow machines), this PR makes the tests finish faster by separating one large suite into multiple (that can run in parallel under |
No description provided.