Skip to content

Implement EventTarget and Event builtin #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andreiltd merged 11 commits into from
Jul 14, 2025
Merged

Implement EventTarget and Event builtin #220

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e72eae0
Implement EventTarget builtin
andreiltd Feb 25, 2025
0499ed8
implement policy-based design for builtin classes
andreiltd Apr 11, 2025
c30d983
Address code review feedback
andreiltd Apr 15, 2025
4f8f068
Add TODO about exception reporting
andreiltd Apr 15, 2025
a0abd76
Change subclass registry from vector to unordered_set
andreiltd Apr 16, 2025
f56b76e
Replace listener instances with RefPtr in the EventTarget listener list
andreiltd Apr 16, 2025
c3ebf87
Remove "once" listeners before dispatch
andreiltd Apr 17, 2025
93d68d0
Defer removing listeners to after the dispatch loop
andreiltd Apr 17, 2025
c8cb3f3
Merge branch 'main' into event-target
andreiltd Apr 17, 2025
461677e
Merge branch 'main' into event-target
andreiltd Jul 14, 2025
8495be3
Addres code review feedback
andreiltd Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions builtins/web/event/custom-event.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ bool CustomEvent::detail_get(JSContext *cx, unsigned argc, JS::Value *vp) {
return true;
}

// https://dom.spec.whatwg.org/#interface-customevent
bool CustomEvent::constructor(JSContext *cx, unsigned argc, JS::Value *vp) {
CTOR_HEADER("CustomEvent", 2);

Expand Down
Loading