Small CMake setup improvements#229
Merged
guybedford merged 1 commit intobytecodealliance:mainfrom Mar 18, 2025
Merged
Conversation
This commit includes two kinds of changes: 1. It makes various tools (binaryen, wasm-tools, wasmtime, weval, and wizer) that are installed during configuration available to embeddings by moving the variables into the CMake variables cache 2. It changes the OpenSSL configuration to ignore patches that are applied multiple times, making the configuration more robust The latter change is needed in situations where an embedding moves to a different version of StarlingMonkey without deleting the build dir. That causes the OpenSSL config to be reapplied, while the old, already patched, files are kept around.
guybedford
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit includes two kinds of changes:
The latter change is needed in situations where an embedding moves to a different version of StarlingMonkey without deleting the build dir. That causes the OpenSSL config to be reapplied, while the old, already patched, files are kept around.