feat(ci): add release github workflow#252
Conversation
Release-As: 0.2.0
|
For reference
|
vados-cosmonic
left a comment
There was a problem hiding this comment.
LGTM 🚀
Left some nits but in general release-please is a great choice
tschneidereit
left a comment
There was a problem hiding this comment.
Thank you for doing this! As mentioned inline, I would prefer keeping the name starling.wasm, but other than that I think we should land this and iterate from there.
|
We should probably start using https://www.conventionalcommits.org/en/v1.0.0/ from now on :) |
|
Hey @tschneidereit would you prefer landing this before or after ff140 update? Edit: BTW I'm happy with either, I just thought it would be useful to have a tag/release before this substantial change, to have a last release with |
|
@andreiltd I agree that landing this before makes sense, so feel free to do that at any point. |
|
D'oh! This failed on main on creating a pull request despite the permissions for a job are explicitly granted: permissions:
contents: write
issues: write
pull-requests: write@vados-cosmonic do you know if this also requires allowing jobs to create a pull request in the repository settings? How jco and componentize-js are configured? |
|
I think what you're missing there is repository configuration! I think in your case it it may be this: An image of what that section looks like (under
We use a bot user in Jco, but I actually don't think Release Please requires that -- See their instructions and this sentence in particular:
If that's already set for StarlingMonkey, then maybe you might need a bot user/explicitly permissioned token! |

Closes: #95
Release-As: 0.2.0