Skip to content

feat(ci): add release github workflow#252

Merged
andreiltd merged 2 commits intobytecodealliance:mainfrom
andreiltd:release-workflow
Aug 3, 2025
Merged

feat(ci): add release github workflow#252
andreiltd merged 2 commits intobytecodealliance:mainfrom
andreiltd:release-workflow

Conversation

@andreiltd
Copy link
Copy Markdown
Member

@andreiltd andreiltd commented Jul 22, 2025

Closes: #95

Release-As: 0.2.0

@andreiltd
Copy link
Copy Markdown
Member Author

For reference

@andreiltd andreiltd requested a review from tschneidereit July 22, 2025 09:43
Copy link
Copy Markdown
Contributor

@vados-cosmonic vados-cosmonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Left some nits but in general release-please is a great choice

Copy link
Copy Markdown
Member

@tschneidereit tschneidereit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this! As mentioned inline, I would prefer keeping the name starling.wasm, but other than that I think we should land this and iterate from there.

@andreiltd
Copy link
Copy Markdown
Member Author

We should probably start using https://www.conventionalcommits.org/en/v1.0.0/ from now on :)

@andreiltd
Copy link
Copy Markdown
Member Author

andreiltd commented Jul 31, 2025

Hey @tschneidereit would you prefer landing this before or after ff140 update?

Edit: BTW I'm happy with either, I just thought it would be useful to have a tag/release before this substantial change, to have a last release with weval clearly labeled.

@tschneidereit
Copy link
Copy Markdown
Member

@andreiltd I agree that landing this before makes sense, so feel free to do that at any point.

@andreiltd andreiltd merged commit 868bf2b into bytecodealliance:main Aug 3, 2025
7 checks passed
@andreiltd
Copy link
Copy Markdown
Member Author

D'oh! This failed on main on creating a pull request despite the permissions for a job are explicitly granted:

    permissions:
      contents: write
      issues: write
      pull-requests: write

@vados-cosmonic do you know if this also requires allowing jobs to create a pull request in the repository settings? How jco and componentize-js are configured?

@vados-cosmonic
Copy link
Copy Markdown
Contributor

I think what you're missing there is repository configuration! I think in your case it it may be this:

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#managing-github-actions-permissions-for-your-repository

An image of what that section looks like (under https://github.com/<org>/<repo>/settings/actions):

image

We use a bot user in Jco, but I actually don't think Release Please requires that -- See their instructions and this sentence in particular:

If your repository is in an organization, you may need to permit github actions to create an approve PRs.

If that's already set for StarlingMonkey, then maybe you might need a bot user/explicitly permissioned token!

@github-actions github-actions bot mentioned this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an automated release process

3 participants