Skip to content

Conversation

@benbrandt
Copy link
Member

Since it seems there is not a need for a branch on your fork, I thought it might be nice to pin instead to one of the version branches in the upstream repository.

Still to do: I think we might need to update the CI cache key to the current commit hash of the submodule.. but I might need to think about how best to do that, and wanted to run the idea of moving to upstream first.

@dicej
Copy link
Collaborator

dicej commented Sep 10, 2024

@benbrandt I'd be happy to switch to the upstream repo, but my understanding is that upstream supports neither shared libraries nor TCP/UDP sockets for WASI, hence my patch: dicej/cpython@118e9d8

Until both of those features are available upstream, I think we'll either need to keep pointing at my fork or else check the patch into this repo and apply it as part of the build process.

@benbrandt
Copy link
Member Author

@dicej ah ok I somehow missed where you had that commit in your repo. No worries

@benbrandt benbrandt closed this Sep 10, 2024
@benbrandt benbrandt deleted the update-cpython branch October 17, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants