prelinking #107
Merged
prelinking #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dicej
approved these changes
Sep 27, 2024
src/lib.rs
Outdated
| futures::future::FutureExt, | ||
| heck::ToSnakeCase, | ||
| indexmap::{IndexMap, IndexSet}, | ||
| prelink::{embedded_helper_utils, embedded_python_standard_library}, |
There was a problem hiding this comment.
Minor style nit: here you're importing these functions directly into scope, but later you call prelink::search_for_libraries_and_configs using the module qualifier (i.e. without importing it into scope). It would be best to be consistent about that, and the prevailing style is to use the module_name::function_name style when calling a freestanding function defined in another module.
TL;DR: let's not import these directly and instead use prelink::embedded_helper_utils and prelink::embedded_python_standard_library to call those functions, respectively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactors some of the prelinking logic from lib.rs into a new file prelink.rs
this starts an effort to make the architecture of the project more closely aligned with the three steps outlined in the presentation: prelink, link and init
https://docs.google.com/presentation/d/1kJ58_G1bApcRq0Ea1qipIVtC97GtMivoFFMzvTeeeqI/edit#slide=id.g27ac897f0bc_0_62