Update deps #108
Merged
Update deps #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Highlights are that all wasm-tools packages and wasmtime are at their latest versions.
benbrandt
commented
Oct 9, 2024
|
|
||
| #[derive(Debug, Copy, Clone)] | ||
| struct MyFloat32(f32); | ||
| struct MyF32(f32); |
There was a problem hiding this comment.
All of these changes were motivated by the WIT spec changing from float to f prefix for these types
| } | ||
|
|
||
| fn drop(&mut self, this: Resource<ThingU32>) -> Result<()> { | ||
| async fn drop(&mut self, this: Resource<ThingU32>) -> Result<()> { |
There was a problem hiding this comment.
This seems related to changes in the wasmtime bindgen in v25
| echo-float32: func(v: float32) -> float32; | ||
| echo-float64: func(v: float64) -> float64; | ||
| echo-f32: func(v: f32) -> f32; | ||
| echo-f64: func(v: f64) -> f64; |
There was a problem hiding this comment.
This was needed because the newer parsers only support the new types
dicej
force-pushed
the
update-deps-20241009
branch
from
2d4b94b to
dc61f34
Compare
|
Thanks, @benbrandt ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights are that all wasm-tools packages and wasmtime are at their latest versions.