Update to pyo3 v0.22.5 #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Second attempt at solving the issues in bytecodealliance#104 This time I didn't need to introduce any extra unsafe, and I think the signatures match the intention of the previous code as best as I can understand.
dicej
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Thanks for persisting on this!
Like I mentioned before, we'll eventually want to do some leak checking to make sure we're not accidentally bumping reference counts too high such that they never go to zero. That was already a hazard before this update, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt at solving the issues in #104
This time I didn't need to introduce any extra unsafe, and I think the signatures match the intention of the previous code as best as I can understand.