Unsigned Integer Handling #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing u64, u32, u16 or u8 values between rust and python the runtime incorrectly handles them as the equivalent signed type which leads to overflows for extreme values. This change adds explicit handling for unsigned types.
I believe this wasn't being caught by the existing tests because the overflow was symmetric in each direction so values would overflow when passed from rust->python and then overflow again when passed in the opposite direction, returning to the initial value. Since the only check being done was that the value returned from the round trip unchanged the tests did not see this happening. This change adds a check in the python guest code which asserts that values which are expected to be unsigned are actually non-negative.
fixes #125