adopt wit-dylib
#171
Open
adopt wit-dylib
#171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the built-in Wasm code generator in favor of `wit-dylib`, which is designed to be reused by interpreters for various languages. It avoids redundant effort and leaves us with less code to maintain overall. This isn't particularly optimized, yet. Given how `wit-dylib[-ffi]` works, we have to acquire and release the CPython GIL a lot more frequently (e.g. for every parameter and result of every import and export call). I haven't measured the overhead in practice, so I don't know if it's significant; if it is, we can make changes to `wit-dylib` to reduce the overhead. Also, `wit-dylib` currently embeds a data section with a lot of metadata that we don't use, so we could slim that down if needed. Otherwise, this should not affect the developer experience in any noticeable way. Signed-off-by: Joel Dice <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the built-in Wasm code generator in favor of
wit-dylib, which is designed to be reused by interpreters for various languages. It avoids redundant effort and leaves us with less code to maintain overall.This isn't particularly optimized, yet. Given how
wit-dylib[-ffi]works, we have to acquire and release the CPython GIL a lot more frequently (e.g. for every parameter and result of every import and export call). I haven't measured the overhead in practice, so I don't know if it's significant; if it is, we can make changes towit-dylibto reduce the overhead. Also,wit-dylibcurrently embeds a data section with a lot of metadata that we don't use, so we could slim that down if needed.Otherwise, this should not affect the developer experience in any noticeable way.