Experimental TypeScript code #822
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cties-in-.ts-bestanden Add explicit types in transpile ts sources
|
Hey Elmer thanks for starting to explore and working on this! I'm going to discuss it at the bext SIG Guest Languages meeting for Javascript (that's happening soon) -- if you'd like to join in feel free to attend or just catch the recording later! |
|
O great! I'd love to join! If I am correct the thing is not scheduled yet right? I'll keep an eye on that link then. Cu then! :-) |
|
Ah hopefully I'm not too late here but to be clear the next meeting will happen -- in roughly ~2 hours! |
|
Oo dear! I am at the gym with my son in 2 hours! I guess I'll check out the recording and maybe next time I can join. Cu soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been translating a small portion of the code to TypeScript to get a feel of the impact this would have.
First I renamed all
.jsfiles I wanted to transform to.ts, then I let some agent (codex) fill in all the missing types for the functions. so far everything was easy and straightforward. Then the work became a bit more difficult and interesting, I walked trought every file to manually transform the rest. The code is transformed with the least amount of effort. Some of the patterns used could (should) be optimized for TypeScript but nothing too difficult.I feel that this little exercise may already expose some bugs or at least weak spots. There are things like using null when undefined is expected that might cause problems in rare cases, there are are also strings being used when UInt8Arrays are expected that would likely cause more problems. I think TypeScript can provide some real benefit by being more strict about this.
I might introduced some new bugs! Sorry for that, this was just to get a feel of the thing.
Another thing that I notice is that the current setup makes for 4 files (yes, 4!) per module. So we have one .ts file, this is where we should be working in. Then we have a compiles
.jsand.d.tsfile, and then we have a map file,.js.map. We want all of these files, but should they really be in the src folder? Should they really be in the repo? I'd propose a slightly more sophisticated build system to make this more ergonomic. This would then be a task that we do before moving to TypeScript.So like I mentioned before in #717, I am in favor of moving the codebase to TypeScript, and after my little experiment I am even more into doing that! It will not be without any effort, but the sooner we move, the less code we need to move and the earlier we can reap the benefits of this move.
\o/